Should perform clean checkout if update fails

Details

  • Type: Bug Bug
  • Status: Verified Verified
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.0
  • Fix Version/s: 2.2.0
  • Component/s: cvs
  • Labels:
    None
  • Environment:
    Platform: All, OS: All

Description

In a project configured to use CVS update mode, and doing incremental builds (or
faulty clean steps), it can happen that CVS updates produce conflicts. For
example, on occasion what was previously a .cvsignore'd build product becomes
checked into the repository - say, ANTLR-generated files if you no longer wish
to depend on antlr.jar for regular builds. In such cases, "cvs up" fails and the
build breaks. There is no way to correct the build from the admin GUI, either;
you need to log in to the server and delete the workspace.

If a project is configured to use update mode, and the update command fails, I
think Hudson should automatically attempt a clean checkout, in the interests of
robustness and zero maintenance.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kohsuke Kawaguchi added a comment -

Similar issue happens with subversion, when a svn-controlled directory is
deleted first, leaving some local artifacts (like maven's target dir) behind,
and then the directory is added back later.

So this is useful across the board for other SCMS, too.

Show
Kohsuke Kawaguchi added a comment - Similar issue happens with subversion, when a svn-controlled directory is deleted first, leaving some local artifacts (like maven's target dir) behind, and then the directory is added back later. So this is useful across the board for other SCMS, too.
Hide
Permalink
Kohsuke Kawaguchi added a comment -

Note that this is now implemented for Subversion.

In case of CVS, it's bit hard for us to decide when the retry would be appropriate.

Show
Kohsuke Kawaguchi added a comment - Note that this is now implemented for Subversion. In case of CVS, it's bit hard for us to decide when the retry would be appropriate.
Hide
Permalink
jglick added a comment -

For Mercurial, I would love to see every pull preceded by

hg up -C .

to make sure there are no local modifications in the workspace; and every build
finished by the equivalent of

mods=`hg st`
test -z "$mods" || exit

to at least mark a build unstable if after completion it has modified some
source files, deleted them, created non-ignorable build products, etc.

Show
jglick added a comment - For Mercurial, I would love to see every pull preceded by hg up -C . to make sure there are no local modifications in the workspace; and every build finished by the equivalent of mods=`hg st` test -z "$mods" || exit to at least mark a build unstable if after completion it has modified some source files, deleted them, created non-ignorable build products, etc.
Hide
Permalink
nevil added a comment -

Could you please try to reproduce this issue on the latest hudson version? Is this issue still actual or we can close it?

Show
nevil added a comment - Could you please try to reproduce this issue on the latest hudson version? Is this issue still actual or we can close it?
Hide
Permalink
jglick added a comment -

I no longer use CVS, but as far as I know this is still relevant.

Show
jglick added a comment - I no longer use CVS, but as far as I know this is still relevant.
Hide
Permalink
nevil added a comment -

https://github.com/hudson-plugins/cvs-plugin/pull/19

Show
nevil added a comment - https://github.com/hudson-plugins/cvs-plugin/pull/19
Hide
Permalink
gwaymark added a comment -

Cannot reproduce in the test environment setting this to verified please re-open if this re-occurs.

Show
gwaymark added a comment - Cannot reproduce in the test environment setting this to verified please re-open if this re-occurs.

People

  • Assignee:
    nevil
    Reporter:
    jglick
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: