[#HUDSON-5536] DownloadService as of 1.344 does not work with existing tool and update center JSON files - Hudson JIRA

Hudson

DownloadService as of 1.344 does not work with existing tool and update center JSON files

Created: 07/Feb/10 09:29 PM Updated: 08/Feb/10 01:59 PM Resolved: 08/Feb/10 11:30 AM

Component/s:

core

Affects Version/s:

None

Fix Version/s:

None

Issue Links:

Dependency

This issue is blocking:

~~HUDSON-5546~~ Cannot manually trigger a build in revision 344

Duplicate

This issue is duplicated by:

~~HUDSON-5540~~ Hudson 1.344 Console Output doesn't work in realtime with Mozilla Firefox 3.6

~~HUDSON-5546~~ Cannot manually trigger a build in revision 344

~~HUDSON-5537~~ Build Now does not work from Job page or Job/Trend page , only from top level Hudson Dashboard

Description

« Hide

The change for ~~HUDSON-5210~~ breaks all use of the existing downloadService.post instances for all the tools and the update center itself. See http://hudson.pastebin.com/m22c14ec. I'm not sure what to do to fix it.

Sort Order:

[ Permalink | « Hide ]

abayer added a comment - 07/Feb/10 09:35 PM

FYI - as a workaround, redownload the JSON files (http://hudson-ci.org/updates/hudson.tasks.Maven.MavenInstaller.json and the other tools, or http://hudson-ci.org/update-center.json), and remove everything but the actual {} JSON object. Save the file(s) (removing the .json file extension for the tools, though not for update-center.json) and you should be able to function.

[ Permalink | « Hide ]

mindless added a comment - 08/Feb/10 09:55 AM

I added an onException handler in downloadService.post and found it was getting an exception in nslXMLHttpRequest.setRequestHeader (with mac firefox 3.5).. seems the requestHeaders parameter to Ajax.Request is required.. adding requestHeaders:[] seems to resolve the problem.

[ Permalink | « Hide ]

mindless added a comment - 08/Feb/10 10:33 AM

I'll commit a little fix to avoid js error in firefox after successful update.. kohsuke will commit main fix for the issue (crumb object adds bad header with empty value). This will resolve both update of update center data, and refresh of plugin/hudson upgrade status on the /updateCenter/ page.

[ Permalink | « Hide ]

mindless added a comment - 08/Feb/10 10:34 AM

(the requestHeaders:[] workaround above was just a bandaid for that particular case to overwrite the bad/empty header added elsewhere)

[ Permalink | « Hide ]

kohsuke added a comment - 08/Feb/10 11:15 AM

The root cause was in our modification to Ajax.Request, so this pretty much affects all AJAX activities in Hudson.

[ Permalink | « Hide ]

aheritier added a comment - 08/Feb/10 11:26 AM

ok, I downgrade because I fixed files this morning and probably the update center automatically updated them and broke them again

[ Permalink | « Hide ]

scm_issue_link added a comment - 08/Feb/10 11:30 AM

Code changed in hudson
User: : kohsuke
Path:
branches/rc/test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
branches/rc/test/src/test/java/hudson/model/DownloadServiceTest.java
branches/rc/test/src/test/resources/hudson/model/DownloadServiceTest/testPost.jelly
branches/rc/war/resources/scripts/hudson-behavior.js
trunk/www/changelog.html
http://hudson-ci.org/commit/27147
Log:
[FIXED HUDSON-5536] in 1.345 and added a test case.

[ Permalink | « Hide ]

scm_issue_link added a comment - 08/Feb/10 11:39 AM

Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/model/DownloadService.java
trunk/hudson/main/core/src/main/java/hudson/model/UpdateSite.java
http://hudson-ci.org/commit/27145
Log:
~~HUDSON-5536~~ set text/plain content type in doPostBack response so browser won't
try to parse response (resulting in "no element found" in firefox error console).
Not the fix for 5536 itself, but nice to avoid js error after successful update.