[#HUDSON-5023] Discard old build doesn't work anymore in 1.336 - Hudson JIRA

Hudson

Discard old build doesn't work anymore in 1.336

Created: 06/Dec/09 04:23 AM Updated: 07/Dec/09 11:11 AM Resolved: 06/Dec/09 10:41 AM

Component/s:

core

Affects Version/s:

current

Fix Version/s:

None

File Attachments:

HUDSON-5023 (3 kB)

Description

« Hide

since my upgrade to 1.336 old builds are not anymore cleaned. (using "Max # of builds to keep" to 20)

Sort Order:

[ Permalink | « Hide ]

olamy added a comment - 06/Dec/09 06:58 AM

in fact it's due to ~~HUDSON-5022~~.

[ Permalink | « Hide ]

olamy added a comment - 06/Dec/09 07:02 AM

searching in log (I don't know if it's linked), I found :

Caused by: java.lang.NullPointerException
        at java.lang.String.compareTo(String.java:1176)
        at hudson.model.Job$2.compare(Job.java:432)
        at hudson.model.Job$2.compare(Job.java:426)
        at hudson.widgets.HistoryWidget.doAjax(HistoryWidget.java:163)
        at sun.reflect.GeneratedMethodAccessor150.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:613)
        at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:185)
        at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:101)
        at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:54)
        at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:74)
        at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:30)
        at org.kohsuke.stapler.Stapler.invoke(Stapler.java:492)
        ... 52 more

[ Permalink | « Hide ]

olamy added a comment - 06/Dec/09 07:34 AM

attached a patch which will skip error on a publisher and will continue execute the others.

[ Permalink | « Hide ]

scm_issue_link added a comment - 06/Dec/09 10:41 AM

Code changed in hudson
User: : abayer
Path:
trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=24433
Log:
[FIXED HUDSON-5023] Subsequent publishers should still run even if an earlier publisher throws an exception

[ Permalink | « Hide ]

scm_issue_link added a comment - 07/Dec/09 11:11 AM

Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=24459
Log:
~~HUDSON-5023~~ be more verbose.. write full exception detail in both job console and java Logger,
instead of just writing just e.getMessage() to Logger.