Issue Details (XML | Word | Printable)

Key: HUDSON-2979
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: cliffano
Reporter: cliffano
Votes: 3
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Hudson

Unable to add link on fresh install (FF3.0.5 on OSX)

Created: 05/Feb/09 05:58 AM   Updated: 26/Apr/10 04:44 PM   Resolved: 26/Apr/10 04:44 PM
Component/s: firefox-extension
Affects Version/s: current
Fix Version/s: None

File Attachments: 1. File buildmonitor-1.5-SNAPSHOT-20091208.xpi (359 kB)
2. File buildmonitor-1.5.4-SNAPSHOT-20100424.xpi (358 kB)

Image Attachments:

1. screenshot-MacOS-HudsonBuildMonitor_1.5.3.jpg
(26 kB)
Environment: Platform: All, OS: All


 Description  « Hide

Bug report on behalf of warpian, made on addons.mozilla.org review page, on
February 4, 2009

Simply installed the plugin then tried to add a RSS link from Hudson by using
the context menu (using Firefox 3.0.5 on OSX).

A little popup appears saying:
Unable to add link to Hudson Build Monitor
Please remove one of the existing feeds.

However, there are no feeds in the monitor yet, so I cannot remove anything.

Too bad, would have like to have this plugin work.



Sort Order: Ascending order - Click to sort in descending order
cliffano added a comment - 25/Feb/09 02:34 AM

The only time I can reproduce the similar symptom is only when I manually messed
up the hudson preferences value stored in Firefox.

I don't think it has anything to do with FF on OSX, though I can't say much on
this because I do most of the testing on Linux and Windows. Any OSX users who
can confirm whether Hudson BuildMonitor has this problem on various versions of
FF, please let me know.

If anyone having a similar problem (can't add link to Hudson), try the following:
1. Uninstall the add-on.
2. Type about:config on Firefox url bar.
3. Search for 'hudson'.
4. Delete all preference properties that start with hudson.
5. Reinstall Hudson BuildMonitor.

It's hard to identify the exact cause of this problem with anyone volunteering
to help with investigation/testing.


msawyer added a comment - 15/Sep/09 03:10 PM

I would like to reopen this issue; it appears to be closed due to lack of
ability to reproduce. I can reproduce it constantly, as can a number of other
people in my group.

I am using FireFox 3.0.11, OSX 10.5.8, Hudson monitor 1.0.2, Hudson itself,
1.260. I've fully removed the monitor, ensured all of the hudson.* lines are
removed from the config, and reinstalled, to get the same issue. I have also
attempted to manually configure in the URL's in the about:config page, with
mixed results (they worked the first time I tried, but not now; suspect I may
have the exact URL slightly wrong, though, when I try that way).

Other extensions installed include ForecastFox, FoxClocks, Organize Status Bar,
and Statusable. Other than that, it's pretty much the stock FF.

I'll happily answer any questions on my setup or the details I'm seeing.

Thanks.

Mike


rcohn added a comment - 27/Oct/09 09:56 AM

Fails for me too, even after reinstalling the plugin. I also tried manually
adding a feed on the FF config page.
FF 3.5.3
HBM 1.0.2
MacOSX 10.6.1
It's always worked fine for me on Windows.


drizztdn added a comment - 07/Dec/09 11:19 AM

I am also experiencing this problem. Here's the error that is being returned in the error console.

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: chrome://buildmonitor/content/buildmonitor-control-init.js :: <TOP_LEVEL> :: line 3" data: no]

Hope this helps.

Kevin


cliffano added a comment - 08/Dec/09 04:55 AM

Thank you for the report. I'm sorry it took so long, but I finally managed to test this issue on OS X.

Could you please try the attached buildmonitor-1.5-SNAPSHOT-20091208.xpi?
I managed to get the add link functionality working with Firefox 3.5.5 on Snow Leopard.

If that still doesn't work, could you please also try the workaround:

  • type about:config on Firefox URL bar, press enter
  • search for browser.preferences.instantApply , the default value on OS X should be true, set this to false
  • open up Hudson Build Monitor preferences, on the Feeds tab, fill in the name and feed URL (copy paste from your Hudson instance - the link with text "for all", "for failures", or "for just latest builds")
  • click OK
  • the feed you just entered should appear next to Hudson icon on Firefox status bar

cliffano added a comment - 11/Jan/10 03:26 AM

This issue has been fixed in version 1.5 .

1.5 is still waiting for moderation from Mozilla editors.
It's available for download by logging in to addons.mozilla.org, and then go to Hudson Build Monitor versions page https://addons.mozilla.org/en-US/firefox/addons/versions/7522


m_burger added a comment - 23/Apr/10 12:51 AM

Using 1.5.3 instead of 1.0.2, Hudson Build Monitor shows the OK button, but that button is grayed out.


m_burger added a comment - 23/Apr/10 12:55 AM

For me, this issue still persists.

Mac OS: 10.6.3
Firefox: 3.6.3
Hudson Build Manager: 1.5.3

See screen shot just attached to this issue.


cliffano added a comment - 23/Apr/10 01:11 AM

I still can't reproduce this problem, and I know some other OS X users who could use this add-on just fine.

I suspect there could be other add-ons that cause the problem with Hudson Build Monitor.
I'm now working on version 1.5.4 and I'm cleaning up any leftover global variables which could perhaps 'conflict' with other add-ons'.
I'll attach the SNAPSHOT version to this issue for you to test when it's ready, hopefully that's really it.

m_burger, could you open up Firefox Error Console and let me know if there's any error message when you tried to add link?


m_burger added a comment - 23/Apr/10 01:20 AM

The error console stays empty during the 'add' operation.


cliffano added a comment - 24/Apr/10 05:34 AM

Hi m_burger,

I just noticed from the screenshot you attached to this issue, that you're actually trying to add a feed URL via the preferences window. I misunderstood this, I thought you were trying to add the URL by using the right click context menu 'Add Link To Hudson Build Monitor' that should appear when you right click on a Hudson feed link.

Could you please first try:

  • type about:config on Firefox URL bar, press enter
  • search for browser.preferences.instantApply , the default value on OS X is true, set this to false
  • try adding the feed URL via preferences window

If the OK button is still greyed out, could you please try adding a feed by right-clicking on a Hudson feed URL on Hudson dashboard / job page?

If that still doesn't work, please try the attached buildmonitor-1.5.4-SNAPSHOT-20100424.xpi .


m_burger added a comment - 26/Apr/10 01:56 AM

>> # search for browser.preferences.instantApply , the default value on OS X is true, set this to false

This helped. However, I think it should be possible to add feeds without this little trick.


cliffano added a comment - 26/Apr/10 04:41 AM

The problem is that ondialogaccept doesn't fire on OS X when a dialog window is closed other than using OK button, as explained here http://forums-test.mozillazine.org/viewtopic.php?f=19&t=698285 .

The only way to avoid this altogether is by:

  • not having the ability to add/edit/delete URLs on the preference window.
  • not having the ability to specify a feed name when a URL is added via right click context menu.
    i.e. feed name will be set by the add-on.

Both of which are features that users specifically asked me for.
So far there's no win-win solution, so I have to compromise with OS X users having to configure firefox preference.

If there's no other problem with this issue, I'll close it.


cliffano added a comment - 26/Apr/10 04:44 PM

The reopened issue was resolved by setting specific configuration for OS X users.

Better solution / patch is always welcome, but for now it's a compromise we have to take.